-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusted documentation for the linkType
property found in SimpleList
and SingleFieldList
#8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the possible options for the property linkType
WiXSL
suggested changes
Sep 16, 2022
…Fixed the wording in SingleFieldList docs because the previous one was meant for the reference field.
fzaninotto
requested changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've suggested a few edits.
Co-authored-by: Francois Zaninotto <fzaninotto@gmail.com>
Co-authored-by: Francois Zaninotto <fzaninotto@gmail.com>
Co-authored-by: Francois Zaninotto <fzaninotto@gmail.com>
Co-authored-by: Francois Zaninotto <fzaninotto@gmail.com>
Thanks! |
Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There used to be documentation on the possible options with
linkType
, but this is from an old PR and that part of the documentation changed with time since it's no longer a property inReferenceField
.I have added documentation for the following options for
linkType
:"show"
"edit"
false
Though I did not add documentation for the empty string option
""
, because it has inconsistent behavior withfalse
when used inSimpleList
:""
would not route to other pages, but the buttons will still be clickable.false
would not route to other pages, and the buttons will not be clickable.