Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add ra-data-localforage package #7959

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Feat: Add ra-data-localforage package #7959

merged 4 commits into from
Sep 29, 2022

Conversation

arimet
Copy link
Contributor

@arimet arimet commented Jul 8, 2022

  • Add ra-data-localforage to packages
  • Update Makefile
  • Update DataProviderList.md
  • Update yarn.lock

ra-application

const index = data[resource].findIndex(
(record: { id: any }) => record.id === params.id
);
data[resource][index] = {

Check notice

Code scanning

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
const index = data[resource].findIndex(
(record: { id: Identifier }) => record.id === id
);
data[resource][index] = {

Check notice

Code scanning

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/ra-data-localforage/README.md Outdated Show resolved Hide resolved
packages/ra-data-localforage/README.md Outdated Show resolved Hide resolved
packages/ra-data-localforage/package.json Outdated Show resolved Hide resolved
packages/ra-data-localforage/package.json Outdated Show resolved Hide resolved
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment. Otherwise, all good! 💪

packages/ra-data-localforage/src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@slax57 slax57 added this to the 4.4.0 milestone Sep 29, 2022
@slax57 slax57 merged commit 77e813f into next Sep 29, 2022
@slax57 slax57 deleted the ra-data-local-forage branch September 29, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants