Fix Filter Form overflow on mobile #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show how it looks with the post filter removed so that we can see the filter button? |
djhi
approved these changes
Jul 21, 2022
fzaninotto
reviewed
Jul 21, 2022
|
I don't like this solution, as it pushes the content down on desktop: Before
After
|
antoinefricker
commented
Jul 21, 2022
|
Please consider the update : filters and top toolbar are stuck with a consistent padding Enregistrement.de.l.ecran.2022-07-22.a.08.39.02.mov |
|
I noticed that the Edit and Show views no longer have the same top margin as the List view. This regression is not caused by your PR, but it's recent. As you're working on the design, could you take a look at it? |
fzaninotto
reviewed
Jul 22, 2022
| paddingRight: 0, | ||
| whiteSpace: 'nowrap', | ||
| flex: '0 1 auto', | ||
| minHeight: 'unset !important', |
There was a problem hiding this comment.
I removed that, as agreed, toolbar keeps (again) consistent height on List, Edit and View templates
fzaninotto
reviewed
Jul 22, 2022
|
As discussed, top toolbar height remains consistent between Edit, Create and List templates Enregistrement.de.l.ecran.2022-07-22.a.10.37.45.mov |
fzaninotto
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result is far from perfect but corrects major responsive display errors.
Enregistrement.de.l.ecran.2022-07-08.a.10.23.02.mov
With debug borders (don't appear for real)
Enregistrement.de.l.ecran.2022-07-08.a.10.22.21.mov