Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export missing components #6911

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Fix export missing components #6911

merged 2 commits into from
Nov 29, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 26, 2021

Fixes #6910

@WiXSL WiXSL added the RFR Ready For Review label Nov 26, 2021
djhi
djhi requested changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer export * from './SidebarToggleButton';

@WiXSL WiXSL requested a review from djhi November 29, 2021 11:05
djhi
djhi approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi added this to the 3.19.3 milestone Nov 29, 2021
@djhi djhi merged commit 5395b13 into master Nov 29, 2021
@djhi djhi deleted the fix-components-export branch November 29, 2021 12:21
@WiXSL WiXSL mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.19.3
Development

Successfully merging this pull request may close these issues.

'SidebarToggleButton' is not exported
2 participants
@WiXSL @djhi