Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warning About Unsaved Change #5776

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Fix Warning About Unsaved Change #5776

merged 3 commits into from
Jan 15, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 14, 2021

Fixes #4969, #5267 and #4969

@djhi djhi added the RFR Ready For Review label Jan 14, 2021
@djhi djhi added this to the 3.11.3 milestone Jan 14, 2021
fzaninotto
fzaninotto reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though bug, kudos for finding a fix!

Id really like a unit test to secure the bug in the future, though. As it seems caused by a final-form shortcoming, we must detect if they ever trigger it again.

@djhi djhi mentioned this pull request Jan 15, 2021
Closed
@fzaninotto fzaninotto merged commit 560da38 into master Jan 15, 2021
@fzaninotto fzaninotto deleted the fix-unsaved-changes-warning branch January 15, 2021 17:01
@fzaninotto fzaninotto mentioned this pull request Feb 2, 2021
Closed
@WiXSL WiXSL changed the title Fix Warning Avout Unsaved Change Fix Warning About Unsaved Change Dec 5, 2021
@WiXSL WiXSL mentioned this pull request Dec 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.11.3
Development

Successfully merging this pull request may close these issues.

Warning for unsaved changes when updating a <CheckboxGroupInput>
2 participants
@djhi @fzaninotto