Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Tab component to TypeScript #5342

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Convert Tab component to TypeScript #5342

merged 1 commit into from
Oct 2, 2020

Conversation

fzaninotto
Copy link
Member

Closes #5334

@fzaninotto fzaninotto added the RFR Ready For Review label Oct 2, 2020
Luwangel
Luwangel approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Luwangel Luwangel merged commit e645ec6 into master Oct 2, 2020
@Luwangel Luwangel deleted the tab-typescript branch October 2, 2020 11:58
@Luwangel Luwangel added this to the 3.9.0 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

Tab component Type Definition is incorrect
2 participants
@fzaninotto @Luwangel