Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sidebar component classes #5121

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Fix Sidebar component classes #5121

merged 2 commits into from
Aug 10, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Aug 6, 2020

Fixes #4407.

I needed to use custom classes and I did it like this.
I you have a better implementation I'm all ears.

@WiXSL WiXSL marked this pull request as ready for review August 6, 2020 17:20
@WiXSL WiXSL changed the title Fix sidebar classes Fix Sidebar component classes Aug 6, 2020
djhi
djhi approved these changes Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@djhi djhi added this to the 3.8.0 milestone Aug 10, 2020
@fzaninotto fzaninotto merged commit d7618f7 into marmelab:next Aug 10, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto mentioned this pull request Aug 10, 2020
Closed
@WiXSL WiXSL deleted the fix-sidebar-classes branch August 10, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel left review comments

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WiXSL @fzaninotto @djhi @Luwangel