Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache to usePermissions to avoid uncessessary render #4447

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Add cache to usePermissions to avoid uncessessary render #4447

merged 3 commits into from
Jan 27, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 26, 2020

No description provided.

@djhi djhi added the RFR Ready For Review label Feb 26, 2020
@djhi djhi added this to the 3.2.4 milestone Feb 26, 2020
@fzaninotto fzaninotto changed the base branch from master to next February 28, 2020 10:14
@fzaninotto fzaninotto changed the base branch from next to master February 28, 2020 10:14
@fzaninotto fzaninotto removed this from the 3.2.4 milestone Feb 28, 2020
@fzaninotto
Copy link
Member

This is not a bug fix, and as such it should be PRed against next rather than master

@djhi djhi changed the base branch from master to next February 28, 2020 15:56
@djhi djhi force-pushed the usepermisssions-cache branch from 38ba811 to 885c196 Compare February 28, 2020 15:57
@djhi djhi added this to the 3.3.0 milestone Feb 28, 2020
@fzaninotto fzaninotto removed this from the 3.3.0 milestone Mar 5, 2020
@fzaninotto
Copy link
Member

tests fail, needs rebase

Base automatically changed from next to master June 5, 2020 14:24
@fzaninotto
Copy link
Member

needs to be rebased on next

@djhi djhi force-pushed the usepermisssions-cache branch from 885c196 to 1ab2471 Compare January 20, 2021 08:32
@djhi djhi changed the base branch from master to next January 20, 2021 08:33
@djhi djhi requested a review from fzaninotto January 20, 2021 08:33
@djhi djhi added this to the 3.12 milestone Jan 20, 2021
@djhi djhi force-pushed the usepermisssions-cache branch from ec2f309 to ae71a32 Compare January 20, 2021 13:06
@fzaninotto fzaninotto merged commit 124944b into next Jan 27, 2021
@fzaninotto fzaninotto deleted the usepermisssions-cache branch January 27, 2021 08:30
@fzaninotto
Copy link
Member

In fact, such a cache was already introduced in #5607 under another name. I don't think that we should change the default usePermissions, and I think we should revert this. What do you think?

@djhi djhi mentioned this pull request Jan 28, 2021
Merged
@fzaninotto fzaninotto removed this from the 3.12 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto