Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix default filter values cannot be removed by user #2831

Merged
merged 3 commits into from
Jan 30, 2019
Merged

[RFR] Fix default filter values cannot be removed by user #2831

merged 3 commits into from
Jan 30, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jan 30, 2019 •
edited
Loading

  • Fix code
  • Add e2e test

After:

peek 30-01-2019 10-41

Closes #2472

@fzaninotto fzaninotto changed the title [WIP] Fix default filter values cannot be removed by user [RFR] Fix default filter values cannot be removed by user Jan 30, 2019
@fzaninotto fzaninotto added this to the v2.6.4 milestone Jan 30, 2019
@fzaninotto
Copy link
Member Author

Switching to RFR

@djhi djhi merged commit a466471 into master Jan 30, 2019
@djhi djhi deleted the fix-default-value-filter branch January 30, 2019 11:58
@fzaninotto fzaninotto mentioned this pull request Feb 7, 2019
Closed
@fzaninotto fzaninotto mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi