added suggestion limit prop to AutocompleteInput #2427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djhi I need this improvement also. |
fzaninotto
requested changes
Oct 23, 2018
| @@ -455,6 +462,7 @@ export class AutocompleteInput extends React.Component { | |||
| options, | |||
| } = this.props; | |||
| const { suggestions, searchText } = this.state; | |||
| const slicedSuggestions = this.sliceSuggestions(suggestions); | |||
There was a problem hiding this comment.
The result will be a new array for each render(), which will force a rerender of the autosuggest even if the suggestions didn't change. This is bad, so you should slice when setting the suggestions in the state, not when reading the state.
| @@ -520,6 +528,7 @@ AutocompleteInput.propTypes = { | |||
| translate: PropTypes.func.isRequired, | |||
| translateChoice: PropTypes.bool.isRequired, | |||
| inputValueMatcher: PropTypes.func, | |||
| suggestionLimit: PropTypes.number, | |||
There was a problem hiding this comment.
please document and unit test this new prop
|
Okay, Will do. |
|
Hi! Could you find a few minutes tu update your PR? |
|
No news for too long, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.