Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ra-data-firebase-client #2334

Merged
merged 1 commit into from
Sep 19, 2018
Merged

ra-data-firebase-client #2334

merged 1 commit into from
Sep 19, 2018

Conversation

aymendhaya
Copy link
Contributor

Adding Data Provider for Firebase

@aymendhaya aymendhaya changed the title react-data-firebase ra-data-firebase Sep 19, 2018
@aymendhaya aymendhaya changed the title ra-data-firebase ra-data-firebase-client Sep 19, 2018
@fzaninotto
Copy link
Member

I suspect you PRed against the wrong branch. Can you rebase your PR against master?

@aymendhaya
Copy link
Contributor Author

Ah sorry for that, i already dont know why when i tried to fork react-admin it bring me my already forked admin-on-rest. anyway i will change the target branch.

@aymendhaya aymendhaya changed the base branch from next to master September 19, 2018 11:59
@fzaninotto fzaninotto merged commit 51acc98 into marmelab:master Sep 19, 2018
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.3.2 milestone Sep 19, 2018
@Kmaschta Kmaschta mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@aymendhaya @fzaninotto