Merge pull request #4311 from WiXSL/patch-notification-auto-hide-dura…

…tion Notification component autoHideDuration prop not being used.
marmelab · Jan 17, 2020 · e6b5830 · e6b5830
2 parents dc4ba65 + c4545df
commit e6b5830
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/docs/Theming.md b/docs/Theming.md
@@ -864,7 +864,7 @@ You can override the notification component, for instance to change the notifica
 // in src/MyNotification.js
 import { Notification } from 'react-admin';
 
-const MyNotification = props => <Notification {...props}autoHideDuration={5000} />;
+const MyNotification = props => <Notification {...props} autoHideDuration={5000} />;
 
 export default MyNotification;
 ```

diff --git a/packages/ra-core/src/actions/notificationActions.ts b/packages/ra-core/src/actions/notificationActions.ts
@@ -3,7 +3,7 @@ export const SHOW_NOTIFICATION = 'RA/SHOW_NOTIFICATION';
 export type NotificationType = 'info' | 'warning' | 'error';
 
 interface NotificationOptions {
-    // The type of the notification
+    // The duration in milliseconds the notification is shown
     autoHideDuration?: number;
     // Arguments used to translate the message
     messageArgs?: any;

diff --git a/packages/ra-core/src/sideEffect/useNotify.ts b/packages/ra-core/src/sideEffect/useNotify.ts
@@ -27,12 +27,14 @@ const useNotify = () => {
             message: string,
             type: NotificationType = 'info',
             messageArgs: any = {},
-            undoable: boolean = false
+            undoable: boolean = false,
+            autoHideDuration?: number
         ) => {
             dispatch(
                 showNotification(message, type, {
                     messageArgs,
                     undoable,
+                    autoHideDuration,
                 })
             );
         },