Merge pull request #5837 from marmelab/Fix-warning-syncWithLocation

Fix syncWithLocation DOM warnings when using List
marmelab · Jan 30, 2021 · 9f8ce01 · 9f8ce01
2 parents ff51006 + 99cf8f0
commit 9f8ce01
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/packages/ra-core/src/controller/useListController.ts b/packages/ra-core/src/controller/useListController.ts
@@ -44,7 +44,7 @@ export interface ListProps {
     resource?: string;
     // Wether to synchronize the list parameters with the current location (URL search parameters)
     // This is set to true automatically when a List is used inside a Resource component
-    syncWithLocation: boolean;
+    syncWithLocation?: boolean;
     [key: string]: any;
 }
 

diff --git a/packages/ra-ui-materialui/src/list/List.tsx b/packages/ra-ui-materialui/src/list/List.tsx
@@ -99,6 +99,7 @@ List.propTypes = {
     match: PropTypes.any,
     path: PropTypes.string,
     resource: PropTypes.string.isRequired,
+    syncWithLocation: PropTypes.bool,
 };
 
 List.defaultProps = {

diff --git a/packages/ra-ui-materialui/src/list/ListView.tsx b/packages/ra-ui-materialui/src/list/ListView.tsx
@@ -248,6 +248,7 @@ const sanitizeRestProps: (
     setPerPage = null,
     setSort = null,
     showFilter = null,
+    syncWithLocation = null,
     sort = null,
     total = null,
     ...rest

diff --git a/packages/ra-ui-materialui/src/types.ts b/packages/ra-ui-materialui/src/types.ts
@@ -25,7 +25,7 @@ export interface ListProps extends ResourceComponentProps {
     pagination?: ReactElement | false;
     perPage?: number;
     sort?: SortPayload;
-    syncWithLocation: boolean;
+    syncWithLocation?: boolean;
     title?: string | ReactElement;
 }