Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bin/deploy #926

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Create bin/deploy #926

merged 2 commits into from
Nov 21, 2023

Conversation

hans2103
Copy link
Contributor

@hans2103 hans2103 commented May 17, 2023

I've extended your magnificent setup with this bin command to deploy the changes in my setup.

Might it be useful to others in this project too?

#!/usr/bin/env bash
bin/composer install;
bin/magento maintenance:enable;
bin/cli rm -rf generated/code var/view_preprocessed;

echo "$ bin/magento cache:flush";
bin/magento cache:flush;

echo "$ bin/magento setup:upgrade";
bin/magento setup:upgrade;

echo "$ bin/ magento setup:di:compile";
bin/magento setup:di:compile;

echo "$ bin/magento setup:static-content:deploy nl_NL en_US -f";
bin/magento setup:static-content:deploy nl_NL en_US -f;

bin/magento maintenance:disable;
bin/magento cache:flush;

I've extended your magnificent setup with this bin command to deploy the changes in my setup. 

Might it be useful to others in this project too?
@what-the-diff
Copy link

what-the-diff bot commented May 17, 2023

PR Summary

  • Introduction of New Deployment Script
    A new file named compose/bin/deploy has been added to the project. This file houses a bash script designed to execute the standard deployment process commands for Magento. This addition simplifies the deployment procedure, automating what were previously manual tasks, thus reducing the risk of deployment-related errors.

@hans2103
Copy link
Contributor Author

@markshust is this addition something that can be added to the setup?

@markshust
Copy link
Owner

@hans2103 sorry in the delay, I've been MIA when it came to OSS this year.

Looks great, I like it! I made some updates to standardize this script so it matches the other formats (removing semicolons, etc.) and added the bin/deploy line to the REAMDE so others know how to use it.

Appreciate it! 👍

@markshust markshust merged commit e91eeb9 into markshust:master Nov 21, 2023
1 check passed
@what-the-diff what-the-diff bot mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants