Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better MageOS support #1246

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Better MageOS support #1246

merged 6 commits into from
Nov 27, 2024

Conversation

markshust
Copy link
Owner

No description provided.

markshust and others added 3 commits April 25, 2024 12:18
Co-authored-by: Michael Lehmkuhl <michael@electricpulp.com>
Co-authored-by: Jenyamba <is3kv3@ukr.net>
Co-authored-by: Tu Van <vandinhtuit@gmail.com>
Co-authored-by: Cid Lopes <alannettto@gmail.com>
Copy link

what-the-diff bot commented Nov 15, 2024

PR Summary

  • Update of Magento Version in README Instructions
    The instructions provided in our README file have been updated. We've changed the specified Magento version from 2.4.7 to 2.4.7-p3. This should help developers avoid confusions and download the correct version.

  • Improved Command Parameter Order in README
    To enhance clarity, the order of parameters used in the command bin/download in the README file has been altered. The edition is now specified first, followed by the version.

  • Updated Default Version in Download Script and Parameter Order
    The default version in the compose/bin/download script has been updated to 2.4.7-p3. In addition, we've also rearranged the parameter order in this script to make it easier for developers to specify the edition and version.

  • Updated Command-Line Parameter Order in Script
    The lib/onelinesetup script now accepts command-line parameters for edition and version in a logical sequence. This should result in correct respects to the download command.

@markshust
Copy link
Owner Author

Confirmed working on Mage-OS 1.0.5.

Screenshot 2024-11-27 at 11 55 16 AM

@markshust markshust merged commit 5eca2e2 into release/next Nov 27, 2024
1 check passed
@markshust markshust deleted the feature/mageos-support branch November 27, 2024 16:56
@markshust markshust mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant