Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

remove pyemma.msm.$(msmtools subpackages) #550

Closed
marscher opened this issue Sep 3, 2015 · 7 comments · Fixed by #966
Closed

remove pyemma.msm.$(msmtools subpackages) #550

marscher opened this issue Sep 3, 2015 · 7 comments · Fixed by #966

Comments

@marscher
Copy link
Member

marscher commented Sep 3, 2015

Due to experience in the workshop it is confusing to users, if high-level objects and low-level API mix up in autocomplete (they've chosen to use the low level api, because the naming of desired quantities are more promising).

@marscher marscher added this to the v2.0.1 milestone Sep 3, 2015
@marscher
Copy link
Member Author

marscher commented Sep 3, 2015

Or at least we should trigger a warning, if these functions are used

@franknoe
Copy link
Contributor

franknoe commented Sep 3, 2015

I think that's a good point. PyEMMA has evolved from these low-level
functions, but now that we have a systematic object structure we might
consider msmtools to be completely separate. People can still use them
via import msmtools. It would certainly lead to more well-defined
packages. Let's discuss this after MolKin.

Am 03/09/15 um 14:05 schrieb Martin K. Scherer:

Due to experience in the workshop it is confusing to users, if
high-level objects and low-level API mix up in autocomplete (they've
chosen to use the low level api, because the naming of desired
quantities are more promising).


Reply to this email directly or view it on GitHub
#550.


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

@franknoe
Copy link
Contributor

franknoe commented Sep 4, 2015

Just to be clear: You want to remove these imports in msm.__init__ - correct?

from msmtools import analysis, estimation, generation, dtraj, flux

@marscher
Copy link
Member Author

Exactly - this should go to the next minor release, since it changes the api.

@franknoe
Copy link
Contributor

I agree

@marscher marscher modified the milestones: v2.1, v2.0.2 Oct 30, 2015
@marscher
Copy link
Member Author

We haven't deprecated these packages yet. So removing them now will break the code of your users without a prior warning. So we should post-pone this to eg. 2.2

@franknoe
Copy link
Contributor

yes

Am 22/03/16 um 12:54 schrieb Martin K. Scherer:

We haven't deprecated these packages yet. So removing them now will
break the code of your users without a prior warning. So we should
post-pone this to eg. 2.2


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#550 (comment)


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

@marscher marscher added this to the 2.3 milestone May 17, 2016
marscher added a commit to marscher/PyEMMA that referenced this issue May 17, 2016
…d module.

This adresses markovmodel#550. Remove those packages again in version 2.3
marscher added a commit to marscher/PyEMMA that referenced this issue May 18, 2016
…d module.

This adresses markovmodel#550. Remove those packages again in version 2.3
marscher added a commit that referenced this issue May 18, 2016
…d module. (#805)

* [msm] use IPython's ShimModule approach to warn upon access of a moved module.

* This addresses #550. Remove those packages again in version 2.3
* remove io->dtraj alias (has already been deprecated ages ago)
* fix #806
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants