Fixes #705 - Throw error when the root HTML element has a dynamic id …

…attribute.
marko-js · May 31, 2017 · f73c236 · f73c236
1 parent fe60da9
commit f73c236
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/components/taglib/TransformHelper/handleRootNodes.js b/src/components/taglib/TransformHelper/handleRootNodes.js
@@ -199,9 +199,16 @@ module.exports = function handleRootNodes() {
                     hasLegacyExplicitBind = true;
                 } else {
                     if (node.hasAttribute('id')) {
+                        let id = node.getAttributeValue('id');
+
+                        if (id && id.name) {
+                            context.addError('Root HTML element should not have a dynamic `id` attribute');
+                            return;
+                        }
+
                         hasIdCount++;
                         nodeWithAssignedId = node;
-                        assignedId = node.getAttributeValue('id');
+                        assignedId = id;
                     }
 
                     if (tagName === 'style') {

diff --git a/test/autotests/render/error-variable-id-root-node/template.marko b/test/autotests/render/error-variable-id-root-node/template.marko
@@ -0,0 +1,3 @@
+$ var id = 'abc123';
+
+<div id=id/>
diff --git a/test/autotests/render/error-variable-id-root-node/test.js b/test/autotests/render/error-variable-id-root-node/test.js
@@ -0,0 +1,6 @@
+var expect = require('chai').expect;
+
+exports.checkError = function(e) {
+    var message = e.toString();
+    expect(message).to.contain('Root HTML element should not have a dynamic `id` attribute');
+};