Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a LICENSE file so that lawyers can be happy #1355

Closed
wants to merge 1 commit into from

Conversation

chrisjshull
Copy link

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Oct 17, 2018

Hi Chris, this looks like a duplicate of #1343

@chrisjshull
Copy link
Author

Hmm. docs/ is excluded from npm by .npmignore, so it is not being distributed.
Also, automated tools expect LICENSE to be in a consistent place.

@joshbruce
Copy link
Member

Maybe we should figure something out about this license thing. The fact that two people have submitted PRs to make the structure more like that commonly found on GitHub makes me think there's a UX goal we're missing.

@styfle
Copy link
Member

styfle commented Oct 17, 2018

Agreed. Let's move the file back instead of creating a new file. That way git log will follow the history.

@chrisjshull Would you like to create a new PR?

@chrisjshull
Copy link
Author

Don't actually have this checked out, just did in the GH UI, but not seeing the option to move.
Can someone else?

@Martii
Copy link
Contributor

Martii commented Oct 17, 2018

@joshbruce

Paralegal in the house! ;)

Maybe we should figure something out about this license thing.

LICENSE can be specific to GH to show in a web browser immediately what the licensing is and the file itself is used for checkouts as common practice with OSS. It's quite picky with dual/double licensing but single licensing works well.

The type of license should be the same reference as by it's SPDX short name at /markedjs/marked/blob/4dce02d/package.json#L14 which is npm specific.

These are usually the first two places we look when adopting a package. :)

Ref:

@Martii
Copy link
Contributor

Martii commented Oct 17, 2018

@chrisjshull

Clone your fork of this repo and then checkout the branch at https://github.com/chrisjshull/marked/tree/patch-1 ... then you can undo ( git rm source) and move using git mv source target and then push to this PR/branch.

@styfle styfle mentioned this pull request Oct 17, 2018
5 tasks
@styfle
Copy link
Member

styfle commented Oct 17, 2018

I went ahead and made PR #1356

@styfle styfle closed this Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants