Import config at build time #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1730a55 to
aecd247
Compare
853205a to
968c3b1
Compare
a3e233b to
f9f5d46
Compare
mfix-stripe
commented
Jul 21, 2022
| case 'critical': { | ||
| logger.error(e.error.message); | ||
| break; | ||
| // https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/176#issuecomment-683150213 |
There was a problem hiding this comment.
Fast refresh doesn't work during child compilation (which is effectively what importModule is doing). This hack seems to fix it just fine, though. I'm going to chat with the Next.js maintainers to see if there is anything else we can do about this.
matv-stripe
reviewed
Jul 21, 2022
| global.$RefreshReg$ = noop; | ||
| global.$RefreshSig$ = () => noop; | ||
|
|
||
| const importAtBuildTime = async (resource) => { |
There was a problem hiding this comment.
thoughts on adding a comment here explaining this imports a "runtime" object in memory, where the runtime one creates a build time string that eventually causes a runtime import
matv-stripe
approved these changes
Jul 21, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By importing the config at build time, we are able to run
Markdoc.validatewith the config that will be used at runtime.Closes markdoc/markdoc#129