update stdio handling of env

mark3labs · Dec 18, 2024 · 51148fa · 51148fa
1 parent d920654
commit 51148fa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/client/stdio.go b/client/stdio.go
@@ -6,6 +6,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"os"
 	"os/exec"
 	"sync"
 	"sync/atomic"
@@ -41,7 +42,10 @@ func NewStdioMCPClient(
 ) (*StdioMCPClient, error) {
 	cmd := exec.Command(command, args...)
 
-	cmd.Env = env
+	mergedEnv := os.Environ()
+	mergedEnv = append(mergedEnv, env...)
+
+	cmd.Env = mergedEnv
 
 	stdin, err := cmd.StdinPipe()
 	if err != nil {

diff --git a/examples/filesystem_stdio_client/main.go b/examples/filesystem_stdio_client/main.go
@@ -12,13 +12,11 @@ import (
 )
 
 func main() {
-	// Create a new client instance
-	// Using npx to run the filesystem server with /tmp as the only allowed directory
 	c, err := client.NewStdioMCPClient(
-		"go",
+		"npx",
 		[]string{}, // Empty ENV
-		"run",
-		"github.com/mark3labs/mcp-filesystem-server@latest",
+		"-y",
+		"@modelcontextprotocol/server-filesystem",
 		"/tmp",
 	)
 	if err != nil {