Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe filling mode #56

Closed
Joelius300 opened this issue Dec 5, 2019 · 1 comment
Closed

Typesafe filling mode #56

Joelius300 opened this issue Dec 5, 2019 · 1 comment
Labels
enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there
Milestone

Comments

@Joelius300
Copy link
Contributor

Describe the feature request

Use the filling modes for Line and Radar chart in a typesafe manner.

The properties are already there in LineDataset and in RadarDataset.

  • In LineDataset it's of type bool so you can only disable it or use 'origin' (alias when true).
  • In RadarDataset it's of type object and there is a description to what values you can use.

Docs

Describe the solution you'd like

We need a class FillingMode (derives from ObjectEnum) where you can use either an int, a string or a bool (private constructors). The supported values are here and you can also see the use cases below.

Here are the use cases we need to support:

  • Fill = FillingMode.Relative(2)
  • Fill = FillingMode.Relative(-1)
  • Fill = FillingMode.Absolute(1)
  • Fill = FillingMode.Disabled -> We might also use FillingMode.Off
  • Fill = FillingMode.Origin
  • Fill = FillingMode.Start
  • Fill = FillingMode.End

A nice to have would be to allow implicit boolean conversion which would be defined like this:

  • false = FillingMode.Disabled
  • true = FillingMode.Origin
@Joelius300 Joelius300 added enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there labels Dec 5, 2019
@Joelius300 Joelius300 added this to the Backlog milestone Apr 9, 2020
@Joelius300
Copy link
Contributor Author

Should be done as part of #96.

Joelius300 added a commit to Joelius300/ChartJs.Blazor that referenced this issue May 15, 2020
Joelius300 added a commit to Joelius300/ChartJs.Blazor that referenced this issue May 15, 2020
Joelius300 added a commit to Joelius300/ChartJs.Blazor that referenced this issue May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request from migration These issues were migrated from Joelius300s repository and more information can be found there
Projects
None yet
Development

No branches or pull requests

1 participant