Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded functionality #52

Merged
merged 11 commits into from
Aug 13, 2022
Merged

Expanded functionality #52

merged 11 commits into from
Aug 13, 2022

Conversation

Vosbrucke
Copy link
Contributor

Hi, I created some new functions to the package. Most of them are based on activities.csv file but there are also some changes to already existing functions. At first I started with the idea to implement colors by activity type in plot_facets and then to explore further possibilities with the data. Bear in mind that I heard about R only a couple months ago so there may be some things which could have been made much easier and faster. Please, feel free to make or suggest changes.

@hugovk
Copy link
Contributor

hugovk commented Aug 1, 2022

Please could you remove the .DS_Store files, and list .DS_Store in .gitignore?

@Vosbrucke
Copy link
Contributor Author

I changed it. Is it ok now?

@hugovk
Copy link
Contributor

hugovk commented Aug 1, 2022

Thanks! I'll let others who are more familiar with R review the actual code.

@marcusvolz
Copy link
Owner

I will review on the weekend, thank you!

@marcusvolz
Copy link
Owner

marcusvolz commented Aug 6, 2022

@Vosbrucke Thank you for the new visualizations and updates to existing visualizations, they look great!

I have reviewed the code briefly and it looks good to me, although I have not had a chance yet to create the plots with my own data.

I note that a Google Maps API key is required to create the individual plot map. Perhaps you could add to the readme user instructions on how to do this.

@datawookie @mihagazvoda If either of you have time and would be interested to review this PR it would be appreciated! Otherwise I'm happy to merge.

@marcusvolz marcusvolz requested a review from datawookie August 6, 2022 10:39
Added user instruction to individual_plot_map function and explanation of process_activities function possibilities.
@Vosbrucke
Copy link
Contributor Author

@marcusvolz Thanks for the response.

You are right about the API key. I have made changes to README file where I added info on how to access Google API key and what possibilities functions dependent on the output of process_activities have.

I am also thinking about providing example data but this is something I will do in the future.

@marcusvolz marcusvolz merged commit b071bb7 into marcusvolz:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants