Rewrite khinsider #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Releasing v2 as it has an autoupdater so can incrementally do the rest. |
terinjokes
reviewed
Jan 13, 2022
| _ = doc.Find("#EchoTopic table:not(#songList) tr div a").Each(func(i int, s *goquery.Selection) { | ||
| coverUrl, exists := s.Attr("href") | ||
| if exists { | ||
| // TODO: Use proper escaping. Tried stdlib but it escaped everything |
There was a problem hiding this comment.
I don't remember anymore but I think there were some covers that were served with spaces which caused me trouble somewhere down the line.
| songMeta := make(map[int]string) | ||
| _ = doc.Find("#songlist_header th").Each(func(i int, s *goquery.Selection) { | ||
| header := strings.TrimSpace(s.Text()) | ||
| if header == "CD" { |
There was a problem hiding this comment.
This (and songMeta[i] below) might be clearer with a switch.
| songMeta[i] = "TrackLength" | ||
| songMeta[i+1] = "MP3FileSize" | ||
| } | ||
| if header == "FLAC" { |
There was a problem hiding this comment.
Some albums have WAV, OGG, and M4A that might be worth tracking as well.
There was a problem hiding this comment.
Yeah, eventually I'll add those but currently it just defaults to MP3 so even tracking FLAC is a bit pointless. It needs a bit more investigation into how the page layouts look for those other formats.
This was referenced Jan 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full rewrite with a changelog coming sometime soon
Closes: #5
Closes: #1