feat: event test:bail

marco-ippolito · Aug 17, 2023 · c400ed1 · c400ed1
1 parent a314a59
commit c400ed1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 1 deletion.
diff --git a/lib/internal/test_runner/reporter/tap.js b/lib/internal/test_runner/reporter/tap.js
@@ -63,6 +63,9 @@ async function * tapReporter(source) {
       case 'test:coverage':
         yield getCoverageReport(indent(data.nesting), data.summary, '# ', '');
         break;
+      case 'test:bail':
+        yield `Bail out! ${tapEscape(data.reason)}\n`;
+        break;
     }
   }
 }

diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -503,7 +503,7 @@ class Test extends AsyncResource {
     this.endTime = hrtime();
     this.passed = false;
     this.error = err;
-    if (bail) {
+    if (bail && !this.root.bailedOut) {
       this.root.bailedOut = true;
       this.root.postRun();
     }
@@ -754,6 +754,10 @@ class Test extends AsyncResource {
         reporter.diagnostic(nesting, loc, diagnostics[i]);
       }
 
+      if(this.bailedOut){
+        reporter.bail();
+      }
+
       reporter.diagnostic(nesting, loc, `tests ${harness.counters.all}`);
       reporter.diagnostic(nesting, loc, `suites ${harness.counters.suites}`);
       reporter.diagnostic(nesting, loc, `pass ${harness.counters.passed}`);

diff --git a/lib/internal/test_runner/tests_stream.js b/lib/internal/test_runner/tests_stream.js
@@ -62,6 +62,13 @@ class TestsStream extends Readable {
     });
   }
 
+  bail(reason = ''){
+    this[kEmitMessage]('test:bail', {
+      __proto__: null,
+      reason,
+    });
+  }
+
   getSkip(reason = undefined) {
     return { __proto__: null, skip: reason ?? true };
   }

diff --git a/test/parallel/test-runner-bail.js b/test/parallel/test-runner-bail.js
@@ -32,6 +32,7 @@ describe('node:test bail tap', () => {
     assert.match(child.stdout.toString(), /not ok 2 - second/);
     assert.doesNotMatch(child.stdout.toString(), /ok 3 - third/);
     assert.match(child.stdout.toString(), /not ok 1 - nested/);
+    assert.match(child.stdout.toString(), /Bail out!/);
     assert.doesNotMatch(child.stdout.toString(), /# Subtest: top level/);
     assert.doesNotMatch(child.stdout.toString(), /ok 1 - ok forth/);
     assert.doesNotMatch(child.stdout.toString(), /not ok 2 - fifth/);