Skip to content

Commit

Permalink
Bug 1924905 [wpt PR 48634] - [Editing] Double-click selects wrong ran…
Browse files Browse the repository at this point in the history
…ge for any element styled as float., a=testonly

Automatic update from web-platform-tests
[Editing] Double-click selects wrong range for any element styled
as float.

The CL addresses the bug where double click on any list item
selects multiple list items when list item has floating style.
When there are multiple list items and anyone is selected using
double click, it selects all the list items along with the one
on which double click was performed. This happens because in
|ComputeInlineContentsAsBlockFlow|, float style is not considered
as text segment boundary and the selection is expanded for all.

Also, for other cases involving floating style on element, the
selection is not as expected as selecting a float element by
double click selects everything. This is fixed by removing the
condition which expands the selection when the element has a
floating style.

Firefox has the behavior similar to what we get after the fix
i.e it doesn't expand the selection for floating elements. Webkit
however, seems to have the same bug as chromium expanding the
selection for floating elements.

Bug: 40711666
Change-Id: I408b388cfd0cb5a8213ef2c433b547376ff83367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5842631
Reviewed-by: Kent Tamura <tkentchromium.org>
Commit-Queue: Pranav Modi <pranavmodimicrosoft.com>
Reviewed-by: Sanket Joshi <sajosmicrosoft.com>
Reviewed-by: Siye Liu <siliumicrosoft.com>
Cr-Commit-Position: refs/heads/main{#1369172}

--

wpt-commits: 721205f92ea832a0197975112a48f5355c8bfcbf
wpt-pr: 48634

UltraBlame original commit: 9276fd5b03a88966892fb844c32083786cdc1bfe
  • Loading branch information
marco-c committed Oct 22, 2024
1 parent b59a5a4 commit b760e78
Show file tree
Hide file tree
Showing 2 changed files with 1,009 additions and 0 deletions.
Loading

0 comments on commit b760e78

Please sign in to comment.