Remove unsafe_html lint rule #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unsafe_html lint rule was not meant for external usage. It was implemented for internal usage, before there was a set of internal lint rules. This rule is not maintained, and does not have any external design. It is also meant to be used with cannot-ignore and in a VCS where specific owners have rights to specific files. None of this applies to this repo. Additionally, the rule only helps with dart:html elements, which is a library that is not imported anywhere in the flutter/flutter repository.
|
CC @marcglasberg this PR is blocking a Dart change to remove the unsafe_html lint rule. Please review ASAP. |
marcglasberg
approved these changes
Oct 29, 2024
15 tasks
srawlins
added a commit
to flutter/tests
that referenced
this pull request
Nov 6, 2024
e32fabf854927bb4c0c0284624bf30c20c4aab8d includes marcglasberg/assorted_layout_widgets#34, a fix to unblock removing the `unsafe_html` lint rule.
8 tasks
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Nov 6, 2024
…b8d (#422) e32fabf854927bb4c0c0284624bf30c20c4aab8d includes marcglasberg/assorted_layout_widgets#34, a fix to unblock removing the `unsafe_html` lint rule, https://github.com/dart-lang/linter/issues/5001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsafe_html lint rule was not meant for external usage. It was implemented for internal usage, before there was a set of internal lint rules.
This rule is not maintained, and does not have any external design. It is also meant to be used with cannot-ignore and in a VCS where specific owners have rights to specific files. None of this applies to this repo. Additionally, the rule only helps with dart:html elements, which is a library that is not imported anywhere in this repository.
See also dart-lang/sdk#57099 and flutter/flutter#157530