bdist_mac: move set_relative_reference_paths to build_exe #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
==========================================
- Coverage 51.68% 51.63% -0.05%
==========================================
Files 72 72
Lines 5932 5928 -4
==========================================
- Hits 3066 3061 -5
- Misses 2866 2867 +1
☔ View full report in Codecov by Sentry. |
|
@TechnicalPirate Can you or @johan-ronnkvist check if this does not break your code/project? |
|
Hi Marcel, I'd like to look at this but I'm sadly no longer assigned to the project/team I was so have lost access to the test-infrastructure i was using. 😢 I hope i can recreate some of it in my new role... If i get a window of opportunity to run these tests i will and report back - but right now i can't promise anything. |
|
Alright, Joe. Success in the new role... Marcelo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus of this change is the separation of stages, and the result is that it solves some problems. Placing set_relative_reference_paths in the build_exe step corrects all rpaths without sharing a 'freezer' object between build_exe and bdist_mac and thus build_exe is complete. After that, samples (pyside2, pyqt5, etc.) that previously gave an error if run using just build_exe, are now run. And with bdist_mac they also run. To use codesign and notarization you will need the bdist_mac/bdist_dmg step.
This PR depends on #2107