Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdist_mac: Copy build_exe to Resources and move executables to MacOS #2048

Merged
merged 1 commit into from
Sep 19, 2023
Merged

bdist_mac: Copy build_exe to Resources and move executables to MacOS #2048

merged 1 commit into from
Sep 19, 2023

Conversation

marcelotduarte
Copy link
Owner

No description provided.

@marcelotduarte marcelotduarte mentioned this pull request Sep 15, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (899be14) 51.49% compared to head (f82ce54) 51.49%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2048   +/-   ##
=======================================
  Coverage   51.49%   51.49%           
=======================================
  Files          68       68           
  Lines        5793     5793           
=======================================
  Hits         2983     2983           
  Misses       2810     2810
Files Changed Coverage Δ
cx_Freeze/__init__.py 97.82% <100.00%> (ø)
cx_Freeze/command/bdist_mac.py 50.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelotduarte
Copy link
Owner Author

@TechnicalPirate

@TechnicalPirate
Copy link
Contributor

Hey trying to look at this today but https://marcelotduarte.github.io/packages/cx-freeze/ seems to be down - will try again later! :)

@marcelotduarte
Copy link
Owner Author

@TechnicalPirate Please try again.

@TechnicalPirate
Copy link
Contributor

Works! - Great improvement - ship it! :)

@marcelotduarte marcelotduarte merged commit a22bbf8 into main Sep 19, 2023
@marcelotduarte marcelotduarte deleted the bdist_mac branch September 19, 2023 15:05
marcelotduarte added a commit that referenced this pull request Sep 21, 2023
@marcelotduarte
bdist_mac: Copy build_exe to Resources and move executables to MacOS (#…
03e9fbd 
…2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelotduarte @TechnicalPirate