Fix banner bug

marcelGoerentz · Aug 16, 2024 · e0200f4 · e0200f4
1 parent fdedf45
commit e0200f4
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 39 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -67,6 +67,6 @@ jobs:
           tags: |
             mgoerentz/threadfin:latest
             mgoerentz/threadfin:${{  github.ref_name }}
-            ghcr.io/marcelGoerentz/threadfin:latest
-            ghcr.io/marcelGoerentz/threadfin:${{  github.ref_name }}
+            ghcr.io/marcelgoerentz/threadfin:latest
+            ghcr.io/marcelgoerentz/threadfin:${{  github.ref_name }}
 
diff --git a/html/index.html b/html/index.html
@@ -22,7 +22,6 @@
 <body onload="javascript: PageReady();">
 
   <div class="banner">
-    New Version available! Click <a href="https://github.com/marcelGoerentz/Threadfin/releases/latest">here</a> to download.
   </div>
 
   <div id="loading" class="modal fade">

diff --git a/src/webUI.go b/src/webUI.go
diff --git a/threadfin.go b/threadfin.go
@@ -42,13 +42,13 @@ var GitHub = GitHubStruct{Branch: "Main", User: "marcelGoerentz", Repo: "Threadf
 const Name = "Threadfin"
 
 // Version : Version, die Build Nummer wird in der main func geparst.
-const Version = "1.3.2-beta"
+const Version = "1.3.1-beta"
 
 // DBVersion : Datanbank Version
 const DBVersion = "0.5.0"
 
 // APIVersion : API Version
-const APIVersion = "1.3.2-beta"
+const APIVersion = "1.3.1-beta"
 
 var homeDirectory = fmt.Sprintf("%s%s.%s%s", src.GetUserHomeDirectory(), string(os.PathSeparator), strings.ToLower(Name), string(os.PathSeparator))
 var samplePath = fmt.Sprintf("%spath%sto%sthreadfin%s", string(os.PathSeparator), string(os.PathSeparator), string(os.PathSeparator), string(os.PathSeparator))

diff --git a/ts/banner.ts b/ts/banner.ts
@@ -16,19 +16,21 @@ async function getNewestReleaseFromGithub() {
         const release_version = [release_major_version, release_minor_version, release_build_version]
         let current_version = []
 
-        if (SERVER) {
+        if ('clientInfo' in SERVER) {
             var current_version_string = SERVER["clientInfo"]["version"];
             current_version.push(current_version_string.split(".")[0]);
             current_version.push(current_version_string.split(".")[1][0]);
             current_version.push(current_version_string.split("(")[1][0]);
         }
-        for (let i = 0; i < 3; i++) {
-            if (release_version[i] > current_version[i]) {
-                bannerElement.innerHTML = 'New Version available! Click <a href="https://github.com/marcelGoerentz/Threadfin/releases/latest">here</a> to download.';
-                bannerElement.style.display = 'block'; // Show Banner if newer version is available
-                break
-            } else if (release_version[i] < current_version[i]) {
-                break
+        if (current_version.length !== 0) {
+            for (let i = 0; i < 3; i++) {
+                if (release_version[i] > current_version[i]) {
+                    bannerElement.innerHTML = 'New Version available! Click <a href="https://github.com/marcelGoerentz/Threadfin/releases/latest">here</a> to download.';
+                    bannerElement.style.display = 'block'; // Show Banner if newer version is available
+                    break
+                } else if (release_version[i] < current_version[i]) {
+                    break
+                }
             }
         }
     } else {