Skip to content

Commit

Permalink
west: sign.py: recommend separator -- tool_args always
Browse files Browse the repository at this point in the history
In the following command, the first argument `for_rimage` is passed to
`rimage` whereas `--for west` goes to west.

```
west sign  for_rimage --for west
```

This is somehow valid but we really don't want anyone to do that.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
  • Loading branch information
marc-hb authored and carlescufi committed Dec 15, 2023
1 parent dbc4b2e commit c13cf99
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions scripts/west_commands/sign.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@
west sign -t your_tool -- ARGS_FOR_YOUR_TOOL
The "ARGS_FOR_YOUR_TOOL" value can be any additional
arguments you want to pass to the tool, such as the location of a
signing key etc.
The "ARGS_FOR_YOUR_TOOL" value can be any additional arguments you want to
pass to the tool, such as the location of a signing key etc. Depending on
which sort of ARGS_FOR_YOUR_TOOLS you use, the `--` separator/sentinel may
not always be required. To avoid ambiguity and having to find and
understand POSIX 12.2 Guideline 10, always use `--`.
See tool-specific help below for details.'''

Expand Down

0 comments on commit c13cf99

Please sign in to comment.