remove intl errors from selected context #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d23bad1 to
8fc920a
Compare
jake-low
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Seems reasonable to me. My initial reaction was that I'd rather not suppress errors like this, but after consideration I actually think that we should check for missing translations at build time (npm check-translations or similar) if we want to catch these kinds of errors. You're right that the runtime message gets in the way of more important console errors when developing/debugging.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr suppresses intl errors, this is to reduce clutter when investigating more impactful errors. There errors will now only show up in the un-selected context:
