Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disable task confirmation feature #2516

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Conversation

jschwarz2030
Copy link
Contributor

Resolves: #1906

Users can now override the task confirmation modal, but project and challenge managers can also disable the override.

Requires: maproulette/maproulette-backend#1162

@jake-low
Copy link
Contributor

I think the build issue you're seeing is because I misconfigured Biome so that it's enforcing that imports are sorted during CI, but not actually automatically formatting the imports on commit / when you run yarn run format.

If you run this command it'll sort your imports; committing the result should then fix the CI failure I think.

biome check --formatter-enabled=false --linter-enabled=false --organize-imports-enabled=true --write src

I'll open a PR soon to make it so that yarn run format does this automatically.

jake-low
jake-low previously approved these changes Jan 28, 2025
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschwarz2030 jschwarz2030 merged commit 4148ce3 into main Feb 5, 2025
2 of 4 checks passed
@jschwarz2030 jschwarz2030 deleted the bypass-fixed-modal branch February 5, 2025 18:09
@CollinBeczak CollinBeczak mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to click "I fixed it!" without modal popup
2 participants