Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tasks in task properties widget collapsible #2502

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

CollinBeczak
Copy link
Collaborator

This PR enhances the usability of the task properties widget for bundles.
Screenshot 2024-12-09 at 10 02 08 AM
Screenshot 2024-12-09 at 10 02 20 AM
Screenshot 2024-12-09 at 10 02 57 AM

@CollinBeczak CollinBeczak requested a review from jake-low December 9, 2024 17:04
@CollinBeczak CollinBeczak marked this pull request as ready for review December 9, 2024 17:04
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state management here looks good but for better accessibility I'd suggest switching to using a <details> element, which will also simplify the styling and JSX a bit.

Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for refactoring to use the details/summary elements.

@CollinBeczak CollinBeczak merged commit 7d64b6f into main Dec 30, 2024
5 of 6 checks passed
@CollinBeczak CollinBeczak deleted the make-tasks-in-task-properties-widget-collapsible branch December 30, 2024 21:32
@CollinBeczak CollinBeczak mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants