Prevent codecov from polluting PRs with useless comments #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollinBeczak
approved these changes
Sep 20, 2024
|
agreed, until there are a significant amount of unit tests, and there is an effect to add them, this messages do not help review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it really annoying that Codecov posts a comment on every single PR review (triggering a notification). And I find it extremely hard to review other people's PRs in the web UI when Codecov has put a big warning next to every third line of code saying that it's not covered (like in the screenshot below).
So I'm proposing to silence its comments on PRs. You can still view the coverage report in the "Checks" tab of the PR.
Discussion welcome if you feel that these features are useful and don't want them turned off.