Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feature animation and hover styles #2440

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Sep 17, 2024

Bug 1: The 's' key no longer works as expected. It 'hides' the task features on the task map, and then isnt able to make them visible again. When it was working correctly, it was able to make features visibile again and rerun the animations.

Bug 2: The animations and highlights on features were not working.

Example of animation:
https://github.com/user-attachments/assets/2f317d78-c093-4339-90af-343f9514dc77

Also investigated and fixed some hover styles, but there is more improvements that can be made to better handle more complicated feature types like geometryCollections when it comes to the feature styles.

@CollinBeczak CollinBeczak changed the title Collin beczak/fix feature animation and hover styles fix feature animation and hover styles Sep 17, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 4.19162% with 160 lines in your changes missing coverage. Please review.

Project coverage is 23.94%. Comparing base (f829a77) to head (b250c3b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/TaskPane/TaskMap/TaskMap.js 1.21% 64 Missing and 17 partials ⚠️
src/components/TaskPane/TaskMap/helperFunctions.js 10.90% 41 Missing and 8 partials ⚠️
...s/EnhancedMap/TaskFeatureLayer/TaskFeatureLayer.js 0.00% 22 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
- Coverage   24.04%   23.94%   -0.10%     
==========================================
  Files         650      651       +1     
  Lines       22408    22526     +118     
  Branches     6875     6919      +44     
==========================================
+ Hits         5387     5393       +6     
- Misses      14253    14338      +85     
- Partials     2768     2795      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as ready for review September 18, 2024 04:01
@CollinBeczak CollinBeczak merged commit 05c420a into main Sep 18, 2024
5 of 6 checks passed
@CollinBeczak CollinBeczak deleted the CollinBeczak/fix-feature-animation-and-hover-styles branch September 18, 2024 04:01
@CollinBeczak CollinBeczak mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant