Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag widget rendering bug #2420

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Aug 26, 2024

Resolves: #1596

Also added some tests to the osm data fetching function after noticing some issues:
Test results before change:
Screenshot 2024-08-30 at 2 52 00 PM

All tests pass after change:
Screenshot 2024-08-30 at 2 52 56 PM

Key take aways from the osm data fetching updates:

  1. Easier to read and understand as a new developer
  2. Less code for the same result
  3. Network error, and unfamiliar errors are now cause and thrown allowing for the widgets that use these functions not to completely break.
  4. Network error, and unfamiliar errors are now cause and thrown allowing for the widgets that use these functions not to completely break.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 80.68182% with 17 lines in your changes missing coverage. Please review.

Project coverage is 23.70%. Comparing base (95dca9d) to head (8467e53).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../components/Widgets/TagDiffWidget/TagDiffWidget.js 0.00% 6 Missing and 2 partials ⚠️
src/interactions/Task/AsCooperativeWork.js 0.00% 6 Missing ⚠️
...nents/TagDiffVisualization/TagDiffVisualization.js 0.00% 2 Missing ⚠️
...components/HOCs/WithCurrentTask/WithCurrentTask.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2420      +/-   ##
==========================================
+ Coverage   23.38%   23.70%   +0.32%     
==========================================
  Files         649      649              
  Lines       22514    22476      -38     
  Branches     6902     6911       +9     
==========================================
+ Hits         5264     5329      +65     
+ Misses      14425    14350      -75     
+ Partials     2825     2797      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as ready for review September 3, 2024 18:31
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job with the additional tests

@CollinBeczak CollinBeczak merged commit be91f6e into main Sep 4, 2024
6 checks passed
@CollinBeczak CollinBeczak deleted the CollinBeczak/fix-tag-widget-rendering-bug branch September 4, 2024 20:34
@CollinBeczak CollinBeczak mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed OSM Tag Changes don't load normally when inspecting tasks.
2 participants