Fix bug when fetching user metrics for dashboard header (fixes #2409)

[jake-low]

There were a couple of bugs in WithUserMetrics.componentDidUpdate that prevented it from running when it was supposed to. When the component mounts, props.user is null. Once the user loads, componentDidUpdate is supposed to fetch leaderboard metrics, but since it first checks if prevProps["user"]?.score is truthy, it was doing nothing. This only triggered during full page load; when navigating from another route componentDidMount would run with a non-null user and correctly fetch the metrics. The problem condition wasn't necessary during either mount or update, so I removed it. I also made the update methods async, removed unused arguments, and fixed a bug where { loading: true } would be set if the user had opted out of leaderboards (resulting I think in a spinner being shown forever, though I didn't test to verify this).

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 23.38%. Comparing base (95dca9d) to head (3cb2db0).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...components/HOCs/WithUserMetrics/WithUserMetrics.js	0.00%	20 Missing and 4 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2411   +/-   ##
=======================================
  Coverage   23.38%   23.38%           
=======================================
  Files         649      649           
  Lines       22514    22510    -4     
  Branches     6902     6900    -2     
=======================================
  Hits         5264     5264           
+ Misses      14425    14423    -2     
+ Partials     2825     2823    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CollinBeczak]

LGTM, I made a separate pr #2428 that fixes a second bug with the CircularProgress loader state.