Fix the editor overwrite bug. #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=======================================
Coverage 23.49% 23.50%
=======================================
Files 649 649
Lines 22493 22493
Branches 6926 6926
=======================================
+ Hits 5285 5286 +1
+ Misses 14397 14396 -1
Partials 2811 2811 ☔ View full report in Codecov by Sentry. |
Merged
This was referenced Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When trying to open both the ID editor and rapid at the same time, the one that is opened second overwrites the previous editor(clearing the tab). This can lead to confusion if a user were wanting to work with multiple editors.
Before:
https://github.com/user-attachments/assets/f53e538f-63c8-4f24-968b-2eb593cdb5d1
After:
https://github.com/user-attachments/assets/4618cdba-3d16-457b-bda7-0c080e8ec381