Simplify conditional logic in ActiveTaskControls.js #2398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started making these changes as part of #2397 but realized that they could be kept separate and would be easier to review that way.
This is just a minor style refactor to (IMO) make it slightly easier to tell what version of the completion widget will be shown based on the properties of the task that's currently being worked on. It should have no effect on behavior; all I did was move some terminal
else
branches upwards (making them into early returns) in order to reduce the level of nesting, and factored one complex condition out into a named variable.Tip: check "Hide whitespace" in the diff view settings for this PR to make review easier. Most of the changes shown by default are the result of un-indenting a large
else
block.