Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor task clustering toggles and limits #2333

Merged
merged 4 commits into from
May 13, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented May 13, 2024

Issue: In the previous bundle widget changes, an increase to the cluster count limit(The number of clusters that can show up at once) was increased to accommodate the needs of the widget. This lead to too many clusters on normal maps, which lead to confusing portrayed data.

Solutions: The cluster limit was reverted to its previous value, and the cluster toggle was enabled for the bundle widget map.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.37%. Comparing base (58a1ca4) to head (c672557).

Files Patch % Lines
...ChallengeTaskClusters/WithChallengeTaskClusters.js 0.00% 2 Missing ⚠️
src/components/TaskClusterMap/TaskClusterMap.js 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
- Coverage   23.37%   23.37%   -0.01%     
==========================================
  Files         648      648              
  Lines       22718    22720       +2     
  Branches     7028     7043      +15     
==========================================
  Hits         5311     5311              
- Misses      14544    14545       +1     
- Partials     2863     2864       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as ready for review May 13, 2024 18:48
@CollinBeczak CollinBeczak merged commit 47ca2d1 into main May 13, 2024
4 checks passed
@CollinBeczak CollinBeczak deleted the refactor-task-clustering-toggles branch May 13, 2024 20:25
@CollinBeczak CollinBeczak mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants