Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add view challenge button in task read only modes completion widget #2290

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Add view challenge button to read only mode. Because that widget is used for navigation by users frequently, it always throws me off whenever i don't see an option to navigate, so i added this view challenge button when the user is in read only mode. This also helps with testing allowing for faster navigation, and makes it easier for developers to understand what status that widget is in based on the conditions for that button being visible.

Screenshot 2024-02-29 at 9 25 05 PM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 23.61%. Comparing base (0374c3b) to head (ef50127).

Files Patch % Lines
...skDetails/ActiveTaskControls/ActiveTaskControls.js 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files         648      648           
  Lines       22474    22474           
  Branches     6935     6935           
=======================================
  Hits         5307     5307           
  Misses      14349    14349           
  Partials     2818     2818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndrewPhilbin AndrewPhilbin merged commit 8338840 into main Mar 8, 2024
5 checks passed
@AndrewPhilbin AndrewPhilbin deleted the add-view-challenge-button branch March 8, 2024 23:45
@CollinBeczak CollinBeczak mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants