add id's and htmlFor attributes to labels and inputs #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main feature improvement of this pr: Accessibility: Associating labels with form elements using htmlFor ensures that screen readers can correctly announce the label when a user interacts with the form field. This improves accessibility for users who rely on screen readers or other assistive technologies to navigate the web.
A secondary focus of this pr is to attempt to resolve some of the suggestions in warnings displayed in devtools.
Moving forward with fixing the labels and input error, the structure of mapped element needs to include a unique id whenever a form is include, and the schemas in forms, whenever using a "ui:widget: 'radio' " pattern will need to be fixed as they are causing the "Page Errors"
Example of a radio format is the yes/no option selectors in forms.
