Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions length environment variable #2234

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Jan 11, 2024

This is to help make development and testing of the challenge editor faster. The default is 150.
REACT_APP_CHALLENGE_INSTRUCTIONS_LENGTH=150

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7ddf207) 23.66% compared to head (43054f7) 23.66%.

Files Patch % Lines
src/services/Challenge/Challenge.js 0.00% 2 Missing and 1 partial ⚠️
...es/EditChallenge/BulkSchemas/InstructionsSchema.js 0.00% 0 Missing and 1 partial ⚠️
...lenges/EditChallenge/Schemas/InstructionsSchema.js 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
- Coverage   23.66%   23.66%   -0.01%     
==========================================
  Files         648      648              
  Lines       22386    22390       +4     
  Branches     6909     6912       +3     
==========================================
  Hits         5298     5298              
- Misses      14284    14285       +1     
- Partials     2804     2807       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschwarz2030 jschwarz2030 merged commit 9cceed6 into main Feb 6, 2024
5 checks passed
@jschwarz2030 jschwarz2030 deleted the instructionsLengthEnvironmentVariable branch February 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants