Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conditional variables for new features #2206

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

CollinBeczak
Copy link
Collaborator

Fix when features can and cannot be visible.

  1. Fix when the built in rapid editor can be visible.
  2. Fix when the remove tasks from bundles can be visible.
  3. Fix when mr tags can be visible.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (21f72dc) 23.75% compared to head (10769a5) 23.74%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../components/Widgets/TaskMapWidget/TaskMapWidget.js 0.00% 9 Missing and 4 partials ⚠️
.../components/TaskAnalysisTable/TaskAnalysisTable.js 0.00% 5 Missing and 5 partials ⚠️
src/components/TaskTags/TaskTags.js 0.00% 4 Missing and 3 partials ⚠️
...skDetails/ActiveTaskControls/ActiveTaskControls.js 0.00% 3 Missing and 3 partials ⚠️
...omponents/ReviewTaskControls/ReviewTaskControls.js 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2206      +/-   ##
==========================================
- Coverage   23.75%   23.74%   -0.02%     
==========================================
  Files         648      648              
  Lines       22313    22329      +16     
  Branches     6871     6889      +18     
==========================================
+ Hits         5300     5301       +1     
- Misses      14225    14239      +14     
- Partials     2788     2789       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak marked this pull request as ready for review December 13, 2023 02:38
@jschwarz2030 jschwarz2030 merged commit eacc338 into main Dec 13, 2023
jschwarz2030 pushed a commit that referenced this pull request Dec 13, 2023
* fix conditional variables for new features

* simplify mr tag updates

* refine inbuild rapid editor conditions
@CollinBeczak CollinBeczak deleted the fixConditionalFeatures branch January 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants