Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test and prevent null values on task name setup #1147

Merged
merged 5 commits into from
Sep 3, 2024
Merged

add test and prevent null values on task name setup #1147

merged 5 commits into from
Sep 3, 2024

Conversation

CollinBeczak
Copy link
Contributor

@CollinBeczak CollinBeczak commented Aug 29, 2024 •
edited
Loading

Resolves: maproulette/maproulette3#1761

Also added test for confirmation and to prevent regressions:
Screenshot 2024-08-29 at 2 47 57 PM

Test results before the change:
Screenshot 2024-09-01 at 1 52 46 PM

Key takeaways:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CollinBeczak CollinBeczak marked this pull request as ready for review August 29, 2024 20:13
@CollinBeczak CollinBeczak changed the title Collin beczak/add test and prevent null values on task name setup add test and prevent null values on task name setup Sep 3, 2024
@ljdelight ljdelight self-requested a review September 3, 2024 23:28
ljdelight
ljdelight approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ljdelight ljdelight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljdelight ljdelight merged commit 121d58d into main Sep 3, 2024
9 checks passed
@ljdelight ljdelight deleted the collinBeczak/add-test-and-prevent-null-values-on-task-name-setup branch September 3, 2024 23:39
@CollinBeczak CollinBeczak mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljdelight ljdelight ljdelight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not accept falsey MR ID values
2 participants
@CollinBeczak @ljdelight