Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Edit links in documentations dont work #190 #191

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jun 3, 2022

Resolves [#ISSUE, #ISSUE]

  • docs/ url has been added/updated.
    - [ ] make test has been run locally
    - [ ] tests have been added/updated (if applicable)
    - [ ] CHANGELOG.md has been updated.

[Description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]

@hrshdhgd hrshdhgd requested a review from matentzn June 3, 2022 14:07
paths:
- 'sssom_schema/src/docs/*'
- 'sssom_schema/src/linkml/sssom_schema.yaml'
# paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented out? These are just conditions for when the action should be triggered, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah ... I was hoping you didn't catch it ... just fixed it ..you're too quick. I was debugging the deployment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol 😄 sorry was just waiting for a taxi and saw it coming in

@@ -41,3 +41,4 @@ nav:

site_url: https://mapping-commons.github.io/sssom/
repo_url: https://github.com/mapping-commons/sssom/
edit_uri: "edit/master/sssom_schema/src/docs/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh so it's done! Thanks you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sir!

@matentzn matentzn merged commit 8677117 into master Jun 3, 2022
@matentzn matentzn deleted the fix-urls branch June 3, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants