-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Edit links in documentations dont work #190 #191
Conversation
paths: | ||
- 'sssom_schema/src/docs/*' | ||
- 'sssom_schema/src/linkml/sssom_schema.yaml' | ||
# paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these commented out? These are just conditions for when the action should be triggered, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah ... I was hoping you didn't catch it ... just fixed it ..you're too quick. I was debugging the deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol 😄 sorry was just waiting for a taxi and saw it coming in
@@ -41,3 +41,4 @@ nav: | |||
|
|||
site_url: https://mapping-commons.github.io/sssom/ | |||
repo_url: https://github.com/mapping-commons/sssom/ | |||
edit_uri: "edit/master/sssom_schema/src/docs/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh so it's done! Thanks you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sir!
Resolves [#ISSUE, #ISSUE]
docs/
url has been added/updated.- [ ]make test
has been run locally- [ ] tests have been added/updated (if applicable)- [ ] CHANGELOG.md has been updated.[Description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]