Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes VRTs on-exit for asset mode #311

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Removes VRTs on-exit for asset mode #311

merged 1 commit into from
Jul 25, 2024

Conversation

goergen95
Copy link
Member

  • raster cell values a explicitly read into memory in asset mode
  • VRT files are removed automatically on-exit of .read_raster() to avoid writing too many files on disk when in asset mode

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (157a843) to head (61bdb82).

Files Patch % Lines
R/spatial-utils.R 92.30% 2 Missing ⚠️
R/calc_indicators.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   85.14%   85.16%   +0.01%     
==========================================
  Files          50       50              
  Lines        2269     2272       +3     
==========================================
+ Hits         1932     1935       +3     
  Misses        337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goergen95 goergen95 force-pushed the rework-read-raster branch from 6d28c5c to 60bd6b5 Compare July 25, 2024 09:29
@goergen95 goergen95 force-pushed the rework-read-raster branch from 60bd6b5 to 61bdb82 Compare July 25, 2024 09:37
@goergen95 goergen95 self-assigned this Jul 25, 2024
@goergen95 goergen95 merged commit c0c7b4a into main Jul 25, 2024
10 checks passed
@goergen95 goergen95 deleted the rework-read-raster branch July 25, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant