Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Global Forest Cover to version 1.11 (2000-2023) #272

Closed

Conversation

fBedecarrats
Copy link
Contributor

This PR is to use the latest available verison of global forest cover data.

@fBedecarrats
Copy link
Contributor Author

Adding the corresponding modifications to the documentation.

@goergen95
Copy link
Member

goergen95 commented May 28, 2024

Hi @fBedecarrats, this looks good but it is missing updating the example data sets. I have this already up and running locally and I would like to add my commit to your branch containing your original work. For this to work, you would need to allow upstream maintainers to create commits on your fork (find documentation here). Would you consider adding this so I can share my changes in this PR?

@fBedecarrats
Copy link
Contributor Author

Hi @fBedecarrats, this looks good but it is missing updating the example data sets. I have this already up and running locally and I would like to add my commit to your branch containing your original work. For this to work, you would need to allow upstream maintainers to create commits on your fork (find documentation here). Would you consider adding this so I can share my changes in this PR?

I don't understand because according to the documentation, a checkbox should appear on the PR to enable such commits, but I don't see this ckeckbox anywhere. Did I do something wrong when generating this PR that impedes me to authorize this.

@goergen95
Copy link
Member

Hmm, I am not sure. It should be visible on the right navbar kind of thing. I could imagine that you might have to log in as the BETSAKA organization account?

@goergen95
Copy link
Member

goergen95 commented May 28, 2024

Sorry that I cannot be of further help to find that option. In the meantime a pushed my changes to a new branch containing your changes in this repo (see #277). We could merge from there if you don't mind?

@fBedecarrats
Copy link
Contributor Author

Sorry that I cannot be of further help to find that option. In the meantime a pushed my changes to a new branch containing your changes in this repo (see #277). We could merge from there if you don't mind?

Sorry, I only foked main and I'm having a hard time to rebase from this new branch. I think that I will use this approach instead.
git_2x

Hang on a couple of days and I will submit a new PR.

@goergen95
Copy link
Member

Merged with #277 because the next CRAN release is planned for the end of the week. Thanks!

@fBedecarrats
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants