-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reading raster tiles with temporal dimensions #211
Conversation
Hi, I this fixes the issue, I think. Would you mind to check? I also tried to make the code more understandable. Maybe let's have a discussion about the assumptions used here? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 73.31% 74.40% +1.09%
==========================================
Files 43 43
Lines 1825 1817 -8
==========================================
+ Hits 1338 1352 +14
+ Misses 487 465 -22 ☔ View full report in Codecov by Sentry. |
Sorry, I saw your request too late. I'm testing on my data right now that caused the problem in the first place. |
@goergen95 I think the original problem is solved, but it's still failing for me because the calc_landcover function returns zero-length tibbles instead of NAs. I'm currently going through my data to identify a reproducible example |
But shouldn't that be covered for with 87b99ba? |
I don't have the original error anymore, because my session crashed. But I think I received the new error message from mapme.biodiversity/R/calc_indicators.R Lines 212 to 215 in 87b99ba
This would mean that the landcover indicator returned a zero-length tibble. That's my guess at least. I'm still looking for the offending polygon. |
Oh, I see what you mean now. So there is a bug in the landcover function that is not directly related to this PR. |
You're right, I'll add it as an issue, I managed to find a reprex now, too. |
No description provided.