Update dependencies #778
Update dependencies #778
Conversation
@storybook 6.4.20 blocks most of others like: react 18, webpack 5, and keeps lots of unnecessary dependencies due to chakra 2 dep.
- new webpack dev server options - babel support for async functions in hooks - new uuid import style - automatically open browser for testing
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4705bf8:
|
|
👍 @propheel I'll have a closer look and do some manual testing. |
|
Thank you, sir. I made a number of small decisions along the way that I haven't described, so feel free to comment and I'll also try to describe them. One of regressions to 1.7.0 I found out is that layers cannot be dragged anymore, but it's because span was changed to button and it is not draggable (sortable?) by default. The fix is a one liner, but it's going to be a part of another PR. Or I can add it to this one if you prefer. |
Looks like this is a regression to Console output when trying to drag a layer:
|
|
Just added it, @pathmapper
Technically speaking this was introduced some time ago, so it's not a regression to The fix is to use |
|
Thanks @propheel , but the issue remains - it's not possible to change the layer order by dragging:
|
|
Nice change regarding running the tests 👍 For Chrome two tests are failing. Do they pass on your side?
For Firefox the tests are not running, I get Any idea how to solve this?
|
You're right, @pathmapper . That was a side effect of new array-move lib version adding in-place move. I also fixed initial load warning of selected style.
Thank you 😊
Yes, however with latest version of Chrome (101.0.4951.41) they get stuck at some point ("resolving host" in browser). Will investigate it. Chrome passes CI though.
Yup, I can see the same on CI as well. Seems related to webdriverio/webdriverio#8282 |
|
Nice work @propheel, this PR is a huge step forward 🎉 Thanks for the fixes!
👍
Same on my side, since FF is passing locally and CI is passing for FF + Chrome, this should't block us from merging here :-) Opened #779 to track this is issue. |
This bumps mapbox-gl to 1.13.2 as well as lots of other dependencies like babel, storybook, webpack and webdriverio.
As a result these:
came down to these:
It could have been much better though with React 18 and Webpack 5, but Storybook is not ready yet.
Still we should have #775 covered.
Also configures selenium so it starts server automatically when running tests without the need to run it manually. Changes are reflected in Readme as well.
Open for comments!